-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Spatial Enrichment + Cython #1163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camisowers Builds and tests are running, it's just that the PR expects the originally named workflows to run, however they have been replaced with a simplified set of workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Removes Cython related files and Spatial Enrichment functionality from the repo. Updates the build process to reflect that. Using
uv
instead of regular python GitHub Actions. Updated the README badges.How did you implement your changes
_bootstrapping.pyx
andsetup.py
files.spatial_enrichment
files.uv
for building, testing and publishing. Removedcibuldwheel
components of the workflows.ubuntu-latest
for builds and tests. This simplifies much of the CI workflow and speeds it up. It is a good practice to still test across various Python versions however.Remaining issues
N/A.