Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Spatial Enrichment + Cython #1163

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Oct 5, 2024

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Removes Cython related files and Spatial Enrichment functionality from the repo. Updates the build process to reflect that. Using uv instead of regular python GitHub Actions. Updated the README badges.

How did you implement your changes

  • Removed _bootstrapping.pyx and setup.py files.
  • Removed spatial_enrichment files.
  • Updated GitHub Actions workflows to use uv for building, testing and publishing. Removed cibuldwheel components of the workflows.
    • Due to ark now being a pure python package we do not need to build nor test on multiple platforms, so defaulted to ubuntu-latest for builds and tests. This simplifies much of the CI workflow and speeds it up. It is a good practice to still test across various Python versions however.
  • Freshened up the README badges with some new ones.

Remaining issues
N/A.

@srivarra srivarra linked an issue Oct 5, 2024 that may be closed by this pull request
@srivarra srivarra added enhancement New feature or request dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 5, 2024
@srivarra srivarra marked this pull request as ready for review October 5, 2024 01:04
@srivarra srivarra self-assigned this Oct 5, 2024
Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few additional removals. Also seems like the builds/tests aren't running. Closes #1151 and #1150.

src/ark/analysis/spatial_analysis_utils.py Outdated Show resolved Hide resolved
tests/analysis/spatial_analysis_utils_test.py Outdated Show resolved Hide resolved
@srivarra
Copy link
Contributor Author

srivarra commented Oct 7, 2024

@camisowers Builds and tests are running, it's just that the PR expects the originally named workflows to run, however they have been replaced with a simplified set of workflows.

@srivarra srivarra requested a review from camisowers October 7, 2024 19:06
Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@srivarra srivarra merged commit 4813ad5 into main Oct 7, 2024
8 of 9 checks passed
@srivarra srivarra deleted the remove_spatial_enrichment branch October 7, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
3 participants