This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
$timout to setTimeout in _modelChangeInDirective() #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed $timeout to setTimeout in _modelChangeInDirective function to avoid angular overhead creating a new defer for each marker, when all that is required is a simple delay in execution. The $timeout is not noticeable in Chrome and Firefox however causes substantial freeze/lock in Internet Explorer and Edge after creating new markers. *Note: I don't think the 10 ms delay is required, 0 is a enough, due to the fact that setTimeout queues the execution to occur after the current. However I don't want to cause any new issues, because this solution seems hacky enough.*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed $timeout to setTimeout in _modelChangeInDirective function to avoid angular overhead creating a new defer for each marker, when all that is required is a simple delay in execution. The $timeout is not noticeable in Chrome and Firefox however causes substantial freeze/lock in Internet Explorer and Edge after creating new markers.
Note: I don't think the 10 ms delay is required, 0 is a enough, due to the fact that setTimeout queues the execution to occur after the current. However I don't want to cause any new issues, because this solution seems hacky enough.