refactor: add optional random infix to generated id #32173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Oct 24, 2025
src/cdk/a11y/id-generator.ts
Outdated
| } | ||
|
|
||
| return `${prefix}${counters[prefix]++}`; | ||
| return `${prefix}${randomInfix ? this._infix + '-' : ''}${counters[prefix]++}`; |
There was a problem hiding this comment.
super nit: I'm wondering if we should add the random number as a suffix. I remember that back in the day IDs starting with a number were problematic and in theory the prefix here can be an empty string.
There was a problem hiding this comment.
If the prefix is an empty string then starting with the counter is going to have the same problem. Maybe we can add a letter to the random number like a1234?
ok7sai
force-pushed
the
ng-aria-id-generator
branch
3 times, most recently
from
e4ce50e to
f2ef0e9
Compare
|
Updated API golden. |
crisbeto
approved these changes
Oct 24, 2025
ok7sai
force-pushed
the
ng-aria-id-generator
branch
from
f2ef0e9 to
6271738
Compare
ok7sai
force-pushed
the
ng-aria-id-generator
branch
from
6271738 to
6a9cc78
Compare
ok7sai
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or do we want to create a different id generator only used by aria?