Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): add optional schema name parameter for postgres #227

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix(postgres): add optional schema name parameter for postgres #227

merged 2 commits into from
Oct 20, 2023

Conversation

paulsc54
Copy link
Contributor

Default to public.
Used to let users define table in schema different from public.

@paulsc54
fix(postgres): add optional schema name parameter for postgres
683e37f 
Default to public.
Used to let users define table in schema different from public.
@paulsc54 paulsc54 mentioned this pull request Oct 18, 2023
Closed
@animir
Copy link
Owner

animir commented Oct 19, 2023

@paulsc54 This looks good.
Is it possible there is not public schema in database? Is it possible the default schema is not public?

@paulsc54
Copy link
Contributor Author

Absolutely possible as it depends on the current search path.
I've updated the code accordingly, thanks!

@animir animir merged commit 52cebba into animir:master Oct 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animir animir animir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulsc54 @animir