Skip to content

fix: whiteboard editor icon is glay on App bar #17848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snowtimeglass
Copy link
Contributor

Purpose / Description

Whiteboard editor icon is dark gray on App bar
image

Fixes

N/A

Approach

How Has This Been Tested?

Checked in physical device (Android 11)

Before After
image image
image image
image image
image image
-- image (No adverse effects in the icon in the menu)
-- image (No adverse effects in Settings screen)
-- image (No adverse effects in Appearance screen)
-- image (No adverse effects in Controls screen)

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, links to relevant work and screenshots make it pretty clear

@mikehardy mikehardy added the Needs Second Approval Has one approval, one more approval to merge label Jan 21, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 21, 2025
@lukstbit lukstbit added this pull request to the merge queue Jan 21, 2025
Merged via the queue into ankidroid:main with commit a9b9529 Jan 21, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 21, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Jan 21, 2025
@snowtimeglass snowtimeglass deleted the fix-whiteboard-editor-icon-color branch January 21, 2025 22:12
@david-allison
Copy link
Member

david-allison commented Feb 6, 2025

Note

Starting 2025, translation expenses are no longer eligible

Hi there @snowtimeglass! This is the OpenCollective Notice for PRs merged from 2025-01-01 through 2025-01-31

Starting 2025, we have updated our selection process for Open Collective, and you are eligible for compensation for your work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

This note applies to all PRs merged for this month.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants