-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new reviewer): Keybinds #17928
Open
BrayanDSO
wants to merge
25
commits into
ankidroid:main
Choose a base branch
from
BrayanDSO:controls-newrev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(new reviewer): Keybinds #17928
+1,250
−1,003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is mostly a refactor because it generifies ControlPreference so it can be used in simple screens like the Previewer but it also adds some icons to the control preference dialog
used only once now
used only there
to be reused later
If you want a ReviewerBinding, use its method, and if you want a MappableBinding use its method
to ReviewerBinding
6b5b08e
to
22bf1b0
Compare
so it can be reused in the previewer and in the new reviewer
it can be used to something like a `Destination` flow
22bf1b0
to
0546723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blocked by dependency
Currently blocked by some other dependent / related change
Has Conflicts
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destination
interface #17925Approach
Show answer
,Answer Again/Hard/Good/Easy
,Show hint
andShow all hints
bindable actions to ease the testing process of the PR and for general useHow Has This Been Tested?
Emulator 35
newrev-controls.mp4
Checklist
Please, go through these checks before submitting the PR.