-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new reviewer): tablet layout #17941
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
[comment/non-blocking] Is there any way that a 'smoke test' can be added here [load the UI in the emulated tests]? Having two layouts makes it much more likely that an edit to one layout will break the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks unusual with the counts at the bottom
But, users will get used to it, it's just unfamiliarity on my behalf
Done.
Anki/AnkiMobile has them at the bottom center. So I don't think that will be very unusual. Haven't put it at the bottom center because that either needs more vertical space (like in Anki desktop) or removes the |
711b5bd
to
7cdd718
Compare
I think it's just the feeling of "it's new". Mild concern about misclicks on the undo button and the lack of symmetry if more icons are added (could they be on both the left & right?) But... it's forward progress. Let's do this |
There's the alternative of making the menu size fixed and centralize the buttons instead of extending them, so it would be always symmetrical |
7cdd718
to
acd42bd
Compare
acd42bd
to
d01c2aa
Compare
|
d01c2aa
to
d8edfaf
Compare
2b0af6a
to
5561612
Compare
5561612
to
cc7e967
Compare
Purpose / Description
Improve the new reviewer style in tablets and make it more similar to Anki
Approach
Move the toolbar to the bottom of the screen and put the answer buttons there
How Has This Been Tested?
Emulator 35 in a lot of scenarios with the new reviewer settings (hide system bars; ignore display cutout; frame style; hide answer buttons; menu)
Checklist
Please, go through these checks before submitting the PR.