Conversation
|
@annaeckman Doh, I meant to use my https://github.com/RockyKev account, instead of my game dev account. Woops. Some next steps:
Some future things1 - organize the code to use scss or vite. It's super duper straightforward. You can literally slap it in real fast, or start a brand new vite project (google vite templates) and then just copy/paste your code. Nesting CSS (or SCSS) is a game changer. 2 - Run through checks
Some things that were pretty noticeable - lack of a favicon, giant file-size images, multiple CSS network calls. Vite will also combine all of your CSS files into a single file, which will make 1 call. WAAAY faster.
Everyone likes tailwind because it's utility classes. I personally love it too. For example: Instead of adding
I gave you a hint using CSS variables. You don't have to do everything in this single project!
Best of luck and happy coding! |

@annaeckman I'm going to write this MR like I would at work.
Goal
Modernize this site to use responsive design.
We'll be focusing on mobile first design, where we build out the site on mobile, then scale to tablet, then scale to desktop.
Notes
Rule of thumb: If you're doing hardcoded numbers/math (like percentages or vh/vw) for page layout, you might be setting up a footgun that can break everything around it. Always try with flex first (or grid if you wanna go hard mode)
I set up a tiny variables.css file to get you in the habit of writing code with a single source of truth.
I focused on mobile first design.
@media (min-width X), I added custom code.Testing