Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made select pin adjustable #3

Closed
wants to merge 1 commit into from
Closed

Made select pin adjustable #3

wants to merge 1 commit into from

Conversation

itavero
Copy link

@itavero itavero commented Apr 23, 2014

Adjusted the begin method. It now accepts a single argument, indicating the Slave Select / Chip Select pin.
It defaults to 10, so it should be backwards compatible.

Adjusted the `begin` method. It now accepts a single argument,
indicating the Slave Select / Chip Select pin.
It defaults to 10, so it should be backwards compatible.
@zachwick
Copy link

zachwick commented May 1, 2014

I think that instead of making the CS pin be an argument passed to the ADXL362::begin method, it should instead be an argument passed to the ADXL362::ADXL362 constructor.
I have implemented such a feature (and making the debug setting a per object option) in my "updates" branch which can be found at https://github.com/ZachWick/ADXL362/tree/updates.
I haven't submitted a pull request for these changes yet however because I am waiting to see if @annem will accept my PR ( #4 ) to change the licensing to GNU GPLv3 before I submit more changes.

@itavero
Copy link
Author

itavero commented Jun 6, 2014

Implemented in 640ecd2.

@itavero itavero closed this Jun 6, 2014
@itavero itavero deleted the adjustable-select-pin branch June 6, 2014 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants