-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default arguments #2408
Add default arguments #2408
Conversation
7c4ea5d
to
b64a388
Compare
b64a388
to
e5edbf6
Compare
ed55fa7
to
5e40cd2
Compare
It looks like there's some issue with type checking the default values? The following type checks:
|
Oops. Because |
@paulcadman now default values are typed checked even if they are not used. I've added a negative test for it. |
This PR implements default arguments as described in #2386.
Change list
NameSignature/Builder
so that it can also be used with scoped syntax.Internal.FromConcrete.NamedArguments
so that we insert default values instead of holes when needed.ArityChecking.Checker
so that it inserts default values instead of holes when needed.Limitations
:
can have arguments. E.g., the following is not valid syntax: