Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang formatting #2465

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Update clang formatting #2465

merged 2 commits into from
Oct 23, 2023

Conversation

jonaprieto
Copy link
Collaborator

@jonaprieto jonaprieto commented Oct 23, 2023

Using

clang-format --version
Homebrew clang-format version 17.0.3

@paulcadman
Copy link
Collaborator

Some configuration in pre-commit needs updating to use the new version of clang-format?

@paulcadman
Copy link
Collaborator

Some configuration in pre-commit needs updating to use the new version of clang-format?

Updating the config seems to have fixed it

@jonaprieto
Copy link
Collaborator Author

Updating the config seems to have fixed it

I didn't notice you push, sorry. Btw, I don't know if you noticed that the pre-commit updates to v17.0.3. I was trying to update with homebrew but it's throwing errors.

@paulcadman
Copy link
Collaborator

Updating the config seems to have fixed it

I didn't notice you push, sorry. Btw, I don't know if you noticed that the pre-commit updates to v17.0.3. I was trying to update with homebrew but it's throwing errors.

I was able to update the homebrew formula to v17.0.3 however this may not be the one that you actually use:

There's a copy of clang-format bundled with llvm:

$ which clang-format
/opt/homebrew/opt/llvm@16/bin/clang-format

so if you have homebrew llvm on your PATH, you'll use the copy of clang-format from llvm rather than the one installed from the homebrew formula.

@jonaprieto jonaprieto marked this pull request as draft October 23, 2023 16:00
@jonaprieto jonaprieto marked this pull request as ready for review October 23, 2023 16:09
@jonaprieto jonaprieto merged commit 7b7f06f into main Oct 23, 2023
6 of 8 checks passed
@jonaprieto jonaprieto deleted the clang-formatting branch October 23, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants