Fast nockma eval #2580
Merged
Fast nockma eval #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
fast-nockma-eval
branch
from
08cec32
to
11864d3
Compare
janmasrovira
force-pushed
the
fast-nockma-eval
branch
from
ecb26d5
to
30c822c
Compare
lukaszcz
reviewed
Jan 19, 2024
| @@ -167,7 +172,7 @@ eqStack st = eqSubStack st [] | |||
| unfoldTerm :: Term Natural -> NonEmpty (Term Natural) | |||
| unfoldTerm t = case t of | |||
| TermAtom {} -> t :| [] | |||
| TermCell Cell {..} -> _cellLeft NonEmpty.<| unfoldTerm _cellRight | |||
| TermCell (Cell l r) -> l NonEmpty.<| unfoldTerm r | |||
There was a problem hiding this comment.
Why this change? Doesn't it go against our general style (of using named fields)?
lukaszcz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds annotations to cells to indicate that it is a call to the stdlib and might be evaluated faster in the Haskell evaluator.
The syntax for stdlib calls is as follows:
where
addis the name of the function being called,<args-term>is a nockma term that points to the position of the arguments, and<left-term>and<right-term>are the actual components of the cell.