Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the juvix dev tree compile command #2590

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Add the juvix dev tree compile command #2590

merged 2 commits into from
Jan 27, 2024

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz added this to the 0.6.0 milestone Jan 23, 2024
@lukaszcz lukaszcz self-assigned this Jan 23, 2024
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
@paulcadman paulcadman marked this pull request as ready for review January 25, 2024 19:16
paulcadman
paulcadman previously approved these changes Jan 25, 2024
View reviewed changes
janmasrovira
janmasrovira reviewed Jan 25, 2024
View reviewed changes
app/Commands/Dev/Tree/Compile/Base.hs Show resolved Hide resolved
app/Commands/Dev/Tree/Compile/Base.hs Outdated Show resolved Hide resolved
app/Commands/Dev/Tree/Compile/Base.hs Outdated Show resolved Hide resolved
app/Commands/Dev/Tree/Compile/Options.hs Outdated Show resolved Hide resolved
janmasrovira
janmasrovira requested changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions. Since this was approved before, I'm requiring changes so this doesn't get merged accidentally before looking at the comments

This was referenced Jan 26, 2024
Merged
Merged
Merged
Merged
@janmasrovira janmasrovira merged commit 6649209 into main Jan 27, 2024
4 checks passed
@janmasrovira janmasrovira deleted the tree-compile branch January 27, 2024 07:54
paulcadman pushed a commit that referenced this pull request Jan 29, 2024
@lukaszcz
JuvixTree recursors and transformation framework (#2594)
a5bfba6 
* Generalizes JuvixCore map and fold recursors to work also for
JuvixTree.
* Adds a transformation framework to JuvixTree.
* Adds identity trasformation tests for JuvixTree.
* Depends on #2590 
* Depends on #2589 
* Depends on #2587
paulcadman pushed a commit that referenced this pull request Jan 30, 2024
@lukaszcz
JuvixTree "apply" transformation (#2595)
1153f6b 
* Moves the "apply" transformation from JuivxAsm to JuvixTree. This
transformation removes the `CallClosures` nodes.
* Makes Nockma compilation tests use JuvixTree instead of JuvixAsm
files.
* Depends on #2594 
* Depends on #2590
* Depends on #2589 
* Depends on #2587
paulcadman pushed a commit that referenced this pull request Jan 30, 2024
@lukaszcz
Filter out unreachable functions in JuvixTree (#2597)
15c223d 
* Adds the `FilterUnreachable` transformation in JuvixTree.
* Depends on #2596 
* Depends on #2595 
* Depends on #2594 
* Depends on #2590 
* Depends on #2589 
* Depends on #2587
paulcadman pushed a commit that referenced this pull request Jan 31, 2024
@lukaszcz
JuvixTree smoke tests (#2598)
dc54bbb 
* Adds smoke tests for `juvix dev tree` CLI commands.
* Fixes a bug with printing JuvixAsm.
* Depends on #2597 
* Depends on #2596 
* Depends on #2595 
* Depends on #2594 
* Depends on #2590
janmasrovira pushed a commit that referenced this pull request Jan 31, 2024
@lukaszcz
Options for juvix dev tree read (#2599)
8956e51 
* Adds the `--transforms`, `--eval` and `--no-print` options to the
`juvix dev tree read` command.
* Depends on #2598 
* Depends on #2597 
* Depends on #2596 
* Depends on #2595 
* Depends on #2594 
* Depends on #2590
paulcadman pushed a commit that referenced this pull request Feb 1, 2024
@lukaszcz
JuvixTree negative evaluation tests (#2601)
7b0a11d 
* Adds negative tests for the JuvixTree evaluator
* Depends on #2600 
* Depends on #2599 
* Depends on #2598 
* Depends on #2597 
* Depends on #2596 
* Depends on #2595 
* Depends on #2594 
* Depends on #2590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

@paulcadman paulcadman paulcadman left review comments

Assignees

@lukaszcz lukaszcz

Labels
CLI juvix-tree
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszcz @paulcadman @janmasrovira