Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parsing error for missing @ in named application #3012

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Improve parsing error for missing @ in named application #3012

merged 4 commits into from
Sep 20, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Sep 9, 2024 •
edited
Loading

Example:

module NamedApplicationMissingAt;

type T := t;

fun (a : T)
 : T := t;

main : T := fun {a := t};

The error displays as:
image

@janmasrovira janmasrovira self-assigned this Sep 9, 2024
@janmasrovira janmasrovira force-pushed the better-error-missing-at branch 7 times, most recently from a0160fc to 0d58b61 Compare September 13, 2024 13:41
@janmasrovira janmasrovira marked this pull request as ready for review September 13, 2024 13:45
@paulcadman paulcadman merged commit c09d10d into main Sep 20, 2024
4 checks passed
@paulcadman paulcadman deleted the better-error-missing-at branch September 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@lukaszcz lukaszcz Awaiting requested review from lukaszcz

Assignees

@janmasrovira janmasrovira

Labels
error-messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error messages for named record arguments
2 participants
@janmasrovira @paulcadman