feat: add version warning banner (anoma#1491) #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
approved these changes
Jan 14, 2025
|
|
||
| if ( | ||
| requiredMajor > currentMajor || | ||
| (requiredMajor === currentMajor && requiredMinor > currentMinor) |
There was a problem hiding this comment.
How about using the semver package to compare this?
It'll be easier to read and probably handling border cases as well
There was a problem hiding this comment.
Agreed with you.
Using the compatibility.json file (currently used for the other checks) to exclude patches from the Interface check invalidates the check itself, because it's a local file.
Excluded semver for this reason, but maybe we can use an internal normalize function to achieve the same result. On it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature to verify the interface version for compatibility by dynamically fetching the required version from the remote package.json file hosted on GitHub.
This update aligns the interface version check with the existing validations for the indexer and keychain, ensuring consistency across compatibility checks.
by 5ElementsNodes