feat: fetching known ibc channels from github chain-registry repository #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
approved these changes
Jan 15, 2025
| @@ -3,3 +3,6 @@ | |||
| #rpc_url = "" | |||
| #masp_indexer_url = "" | |||
| #localnet_enabled = false | |||
|
|
|||
| github_chain_registry_base_url = "https://raw.githubusercontent.com/anoma/namada-chain-registry/refs/heads/main" | |||
| github_namada_interface_url = "https://raw.githubusercontent.com/anoma/namada-interface/refs/heads/main" | |||
There was a problem hiding this comment.
I didn't understand the use case of this 🤔
There was a problem hiding this comment.
Just in case someone would want to point to their own chain registry for some reason. Probably won't be used
| ); | ||
| ] as Chain[]; | ||
|
|
||
| cosmosRegistry.chains.push(...namadaTestnetChainList, namadaChain); |
There was a problem hiding this comment.
I vaguely remember having a find() in the code that captures the first item on array, and it needs to be the mainnet, maybe an asset related?
Do you think we could invert parameters to be .push(namadaChain, ...namadaTestnetChainList)?
There was a problem hiding this comment.
Hmmm, I can do it, but this find() is not right :/ if we find this case, we should refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fetch known IBC channels from namada-chain-registry repository, instead of relying on the ibc channels added to Namadillo build. Maybe in the future we can revert these changes, but now we'll need a more dynamic way to fetch the latest changes and info from relayers.
This PR also introduce new config.toml entries:
github_chain_registry_base_url = "https://raw.githubusercontent.com/anoma/namada-chain-registry/refs/heads/main"
github_namada_interface_url = "https://raw.githubusercontent.com/anoma/namada-interface/refs/heads/main"