Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extension - remove old dompurify, switch to new one #1549

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jurevans
Copy link
Collaborator

This resolves the following errors in the Extension:

Uncaught TypeError: (0 , dompurify__WEBPACK_IMPORTED_MODULE_1__.sanitize) is not a function

The above error occurred in the <ApproveConnection> component:

This seems to have been caused when isomorphic-dompurify was introduced, so I switch this (and Faucet) over to the newer version and removed dompurify & @types/dompurify

@jurevans jurevans added bug Something isn't working App: Extension labels Jan 15, 2025
@jurevans jurevans added this to the Phase 3 milestone Jan 15, 2025
@jurevans jurevans self-assigned this Jan 15, 2025
@jurevans jurevans changed the title bug: Extension - remove old dompurify, switch to new one fix: Extension - remove old dompurify, switch to new one Jan 15, 2025
@jurevans jurevans merged commit 51953b1 into main Jan 15, 2025
7 checks passed
@jurevans jurevans deleted the bug/fix-extension-dompurify branch January 15, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Extension bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants