-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pos] Add epoch argument to vp::pos::rewards #4297
Conversation
…st rewards_counter
…re as of beginning of epoch
…larify that it only returns accumulated rewards available to claim
…e state before invoking the shortcut
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4297 +/- ##
==========================================
+ Coverage 74.02% 74.18% +0.16%
==========================================
Files 345 345
Lines 109920 110565 +645
==========================================
+ Hits 81367 82024 +657
+ Misses 28553 28541 -12 ☔ View full report in Codecov by Sentry. |
|
Describe your changes
This adds an
epoch
argument to therewards()
function invp::pos
. It does require a RPC node update in order to work, but it's backwards compatible. Tested with previous build ofnamadan
and results are same as before:With node on
main
and client on this branch:With both client and node on this branch:
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo