Open
Conversation
murisi
force-pushed
the
murisi/generalize-tx-generation
branch
from
2426270 to
ee66d43
Compare
murisi
force-pushed
the
murisi/generalize-tx-generation
branch
from
ee66d43 to
ad39471
Compare
agureev
reviewed
Oct 6, 2025
Comment on lines
+24
to
+25
| uint256 public constant MAX_ACTIONS = 4; | ||
| uint256 public constant MAX_RESOURCES = 5; |
Collaborator
There was a problem hiding this comment.
Do we really want to hardcode these parameters?
Contributor
Author
There was a problem hiding this comment.
Yes, but only in the context of the approach taken by this PR. If there are no limits on action and resource counts, the generator will start sometimes generating transactions with 256 actions, each containing 256 resources (so 65536 resources total), and the fuzz tests, each of which has a 1000 iterations, take impractical amounts of time to complete. But maybe another approach could be taken like removing the limits only for (non-fuzzing) unit tests or something...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to try and generalize test transaction generation, the goal being to ultimately make ordinary and fuzz-based tests cover a larger transaction space. Amongst others, the following generalizations have been achieved:
This generalization was achieved by making tests accept more randomness from the Solidity fuzz tester, and transforming that into well-formed transactions. Confirmed that the protocol adapter executes all these additional variations successfully. This PR is also being used to check the latest proposed changes to the protocol adapter.