Add descriptive messages to all assert statements in tests#489
Open
jonaprieto wants to merge 1 commit intomainfrom
Open
Add descriptive messages to all assert statements in tests#489jonaprieto wants to merge 1 commit intomainfrom
jonaprieto wants to merge 1 commit intomainfrom
Conversation
Add message strings to every assertEq, assertNotEq, assertLt, assertLe, assertTrue, assertFalse call that was missing one across 13 test files. Convert bare assert() calls to assertTrue() with messages since assert() doesn't support message parameters. Refs #380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add message strings to every assert call that was missing one across 13 test files. Converts bare
assert()calls toassertTrue()with messages sinceassert()doesn't support message parameters.