Fix node using itself as anchor resulting in incorrect ordering #552
+82
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where if the node itself is provided to insertBefore as anchor as well, the node gets inserted at the wrong index.
Issue got noticed in a testcase of reversing an array in solid and trigerring a re-render which didn't result in the correct item order.
Tests included at both core and solid level
Also makes non existing anchor a non fatal error.