fix: don't re-capture console in restoreOriginalConsole #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
restoreOriginalConsolemethod was callingsetupConsoleCapture()after restoring the original console, which immediately re-captured it. This preventedconsole.logoutput from appearing afterrenderer.destroy()was called.Problem
When using
createCliRendererand then callingrenderer.destroy(), anyconsole.logstatements after the destroy call would not appear in the terminal. This is because:renderer.destroy()callsthis._console.destroy()deactivate()restoreOriginalConsole()restoreOriginalConsolerestoresglobal.consolebut then immediately callssetupConsoleCapture()which re-captures itSolution
Remove the errant
setupConsoleCapture()call fromrestoreOriginalConsole()so that deactivating the console capture actually restores normal console behavior.Testing
After this fix, the following pattern works correctly: