Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve website structure and style #55

Merged
merged 28 commits into from
Oct 15, 2018
Merged

Conversation

camchenry
Copy link
Contributor

This is a WIP pull request. Do not merge.

I hope these changes are not too trivial to consider. I wanted to work on adding some structure to the site, in anticipation to potentially adding more data and links to things (#21, #22, #48, #19, #26, etc.). I would welcome suggestions/issues that you have and would like me to address.

Before:
image

After:
image
(screenshots taken in Firefox 61, Ubuntu 17.10)

@anp
Copy link
Owner

anp commented Oct 12, 2018

This looks great! Excited to see what else you're working on :).

@camchenry
Copy link
Contributor Author

camchenry commented Oct 13, 2018

Just curious, what are your thoughts on using a CSS framework for this? I'm not opposed either way. So far, I have just been using vanilla CSS to put something together, which has the nice benefit of everything being very lightweight (<70KB). However, a framework could be more consistent and easier for others to learn.

* Changed main font family to Fira
* Added default header sizes
* Added main navigation bar
* Removed table borders
* Added table stripes
* Right-aligned stddev/delta in tables for easier reading
@camchenry
Copy link
Contributor Author

camchenry commented Oct 13, 2018

Okay, here are the latest screenshots. Notable changes:

  • Changed font family to Fira to give that "Rust feel"
  • Changed table styles to make them easier to scan and read, especially on the homepage tables
  • Adjusted anchor links to only show when hovered

I would be willing to merge it at this point, but I'm open to feedback. I'd like to work on some of the other issues. It would probably be good to add more information first and see if we need to adjust the design again.

@camchenry camchenry changed the title WIP: Improve website structure and style Improve website structure and style Oct 13, 2018
@anp
Copy link
Owner

anp commented Oct 14, 2018

@camchenry this is looking really awesome :D. Would you mind rebasing your branch onto master so that the latest CI changes can run? I'd selfishly like to test the screenshotting I added and hopefully I can get the automated deployment working in time for when this is ready to merge.

@camchenry
Copy link
Contributor Author

camchenry commented Oct 15, 2018 via email

@camchenry
Copy link
Contributor Author

Been a while since I rebased, hopefully that looks okay. I suppose you can just squash this pull request later.

@anp anp merged commit de6e060 into anp:master Oct 15, 2018
@anp
Copy link
Owner

anp commented Oct 15, 2018

Thank you so much! I squashed the commits down but kept your messages. Should be live on the site in an hour or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants