Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub & RT task class and package refactor #7

Merged
merged 3 commits into from
Mar 7, 2018
Merged

GitHub & RT task class and package refactor #7

merged 3 commits into from
Mar 7, 2018

Conversation

anrchen
Copy link
Owner

@anrchen anrchen commented Mar 5, 2018

Changes matching (A) and (B) on PR

Changes matching <Initial pass> (A) and (B) on PR
@anrchen
Copy link
Owner Author

anrchen commented Mar 5, 2018

[Updated] GitIssueDetails.java usage:

  1. Go to lib/java folder
    cd lib/java

  2. Compile GitIssueDetails.java using javax.json-1.0.jar as class path
    javac -classpath .:./javax.json-1.0.jar ../../src/java/fp/v11/github/GitHub.java

  3. Go to src/java folder
    cd ../../src/java/fp/v11

  4. Run GitIssueDetails class using javax.json-1.0.jar as class path
    java -classpath .:../../../../lib/java/javax.json-1.0.jar github/GitHub


RtCreateIssue.java usage:

  1. Open project from ..\splints\src\java in Eclipse

  2. Import JAR files:
    a) Right click on the project --> properties --> Java Build Path -->Add external JARS
    b) Go to ..\splints\lib\java and select all JAR files

  3. Change HOSTNAME and run RtCreateIssue.java

Changes matching <Initial pass> (C) on PR
@anrchen anrchen changed the title GitHub task class and package refactor GitHub & RT task class and package refactor Mar 5, 2018
(A)(B)(C) requested changes from PR11
@anrchen
Copy link
Owner Author

anrchen commented Mar 5, 2018

Pull Request 11:

  • (A) This would naturally be github. instead of fp.v11.
  • (B) GitHub is a better class name
  • (C) naturally, should be package rt;
  • (L) I gather this belongs to a partial IntelliJ build system. It should not be in src/; recall your "src" is really under src/java/

Copy link
Collaborator

@ChristBian1 ChristBian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@anrchen anrchen merged commit 8bcddf2 into master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants