Skip to content

CISU converter to easily communicate outside of fr.health #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jan 22, 2025
Merged

CISU converter to easily communicate outside of fr.health #221

merged 32 commits into from
Jan 22, 2025

Conversation

romainfd
Copy link
Collaborator

@romainfd romainfd commented Dec 27, 2024 •
edited
Loading

Linked to ansforge/SAMU-Hub-Sante#280 and https://github.com/ansforge/SAMU-Hub-Config/pull/208

Next steps (remaining ToDos):

  • implement all conversion rules in cisu_converter.py
  • [Low priority] implement INSEE country codes in cisu_converter.py
  • Handle CISU reference version in cisu_converter.py [should actually be OK now that we have all conversion versions at the same time -> just match the name of the class]
  • Implement version conversion in converter.py (for cisu go from source to target version first and then do cisu coversion as the target version should be a valid CISU version and have a converter)
  • 2 * migrate v3 online examples retrieval to correct tag once model v3 is released in test_cisu_converter.py
  • [Low priority] Fix list handling in format_object and uncomment test in test_utils.py

@romainfd romainfd mentioned this pull request Dec 27, 2024
Merged
@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 68.09% 🍏

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

Coverage

Converter - python code coverage
FileStmtsMissCoverMissing
cisu_converter.py57787%58, 74–75, 77–78, 99, 120
converter.py48589%31, 38–39, 63, 72
utils.py47491%20, 57, 67, 79
TOTAL1521689% 

@romainfd romainfd added the WIP Work In Progress: the branch is still under active development and not stable / in a working state label Dec 27, 2024
bou3108
bou3108 reviewed Jan 22, 2025
View reviewed changes
converter/Conversion.ipynb
Comment on lines +1 to +13
{
"cells": [
{
"cell_type": "code",
"execution_count": 1,
"id": "a07ad38f",
"metadata": {},
"outputs": [
{
"name": "stdout",
"output_type": "stream",
"text": [
"Requirement already satisfied: hubsante_model in /Users/romainfouilland/code/envs/all/lib/python3.9/site-packages (0.1.1)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

à quoi sert ce fichier ?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bou3108
Copy link
Collaborator

bou3108 commented Jan 22, 2025

Ok 1er jet

Reste à compléter le fromCISU

bou3108
bou3108 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@bou3108 bou3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 1er jet

Reste à compléter le fromCisu

@bou3108 bou3108 merged commit 438bacc into main Jan 22, 2025
2 checks passed
@bou3108 bou3108 deleted the feat/cisu_conversion branch January 22, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bou3108 bou3108 bou3108 approved these changes

Assignees
No one assigned
Labels
WIP Work In Progress: the branch is still under active development and not stable / in a working state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainfd @bou3108