Feat/Ajout des champ de nack dans RC-REF #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
romainfd
requested changes
Feb 13, 2024
| @@ -26,7 +26,7 @@ public class ReferenceWrapperBuilder { | |||
|
|
|||
| public ReferenceWrapperBuilder(DistributionElement distributionElement, String referencedDistributionId) { | |||
| this.distributionElement = distributionElement; | |||
| this.reference = new Reference().distributionID(referencedDistributionId); | |||
| this.reference = new Reference().distributionID(referencedDistributionId).infoDistributionID(null).refused(false); | |||
There was a problem hiding this comment.
Comme échangé, enlever ces setters, créer les fonctions de chainage du builders ici et reprendre le build() pour controler != true
romainfd
approved these changes
Mar 1, 2024
Comment on lines
+37
to
+40
| public ReferenceWrapperBuilder infoDistributionID(String infoDistributionID) { | ||
| this.reference.setInfoDistributionID(infoDistributionID); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
On aurait limite pu mettre refused = true dans ce cas là aussi par cohérence et ne pas mettre de builder sur refused vu que les 2 vont toujours ensemble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout des champs
au schema RC-REF, et modification des classes associés (Reference et ReferenceWrapperBuilder)