-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable http server at the end of eos_eapi tests #217
base: main
Are you sure you want to change the base?
Enable http server at the end of eos_eapi tests #217
Conversation
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good. I'll leave it up to you whether you take my comment or merge as-is
assert: | ||
that: | ||
- http_config.stdout[0].httpServer.port == 80 | ||
|
||
- name: Expect endpoint other ports to be set as configured | ||
assert: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that there is much value in breaking this down into two separate assert statements. A longer name or even just a comment before the assert task would be fine for me
recheck |
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
HTTP server is disabled as part of eos_eapi test configure.yaml. This PR enables the server at the end of the test.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION