Add integration tests for eAPI with SSL #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-on: ansible-collections/ansible.netcommon#494
SUMMARY
Add integration tests for eAPI with SSL
There is no coverage for SSL with eAPI, which would have shown the SSL Cipher issue introduced with Python 3.10. In Python 3.10 the default ciphers are no longer compatible with current Arista EOS versions, so eAPI connection fail with
[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:997).The issue can be worked around by supplying ciphers manually. Support for this went into
ansible-core2.14 and is being implemented inansible.netcommonin ansible-collections/ansible.netcommon#494.This PR add test cases for regular
eos_commandvia eAPI with SSL. The test case is expected to fail with Python3.10 with the error message mentioned above.For
ansible-core>= 2.14 another test will run setting theansible_httpapi_ciphersas introduced in theansible.netcommonPR referenced above.This PR will not pass CI until ansible-collections/ansible.netcommon#494 has been merged, so it will be left in draft until then.
ISSUE TYPE
COMPONENT NAME
Integration Tests
ADDITIONAL INFORMATION