Implement Context Diff option in eos_config module #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 82.76% 82.80% +0.04%
==========================================
Files 153 153
Lines 11967 11992 +25
==========================================
+ Hits 9904 9930 +26
+ Misses 2063 2062 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
ea58517
to
d0881ae
Compare
rohitthakur2590
had a problem deploying
to
ack
GitHub Actions
Failure
rohitthakur2590
changed the title
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
64c2454
to
fd4240d
Compare
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
1256404
to
1420644
Compare
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
58b1cd1
to
c68972e
Compare
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
7beb609
to
edc6821
Compare
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
273f184
to
5ba12ba
Compare
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
bf16aa3
to
ea5b00b
Compare
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
on_box_diff
branch
from
5f2cbae
to
6d4f4f8
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implements: Allow override of supports_onbox_diff #374
Implement context_diff options when taking the diff between candidate and running,
Context Diff result is based on off-box-diff logic overriding the default arista on-box diff.
context_diff allows the sizing of the context lines w.r.t the diff, this is quite useful
when having a large nested config structure.
To conclude this solves the issue where with on-box diff or default diff implementation the diff context is
limited to a couple of lines.
This is an add-on feature and doesn't affect the existing output format.
ISSUE TYPE
COMPONENT NAME
eos_config
Example
Output:
while on-box diff output would look like