Fix a timeout when deploying multi line banners. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Banner text was being sent in repr() format which trips up the IOS-XR CLI causing it to hang at the prompt waiting for the banner termination character. Instead of trying to wrap the banner in ', put it on the user to specify their own delimiter character.
|
Believe that our group has this issue as well, but have not been able to test the PR. |
sean-m-sullivan
approved these changes
Sep 21, 2020
|
regate |
rohitthakur2590
approved these changes
Sep 22, 2020
|
@xorrkaz Could you please add the changelog fragment before we merge this. |
|
Sorry, I missed the request earlier. I have added a fragment now. |
|
regate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Banner text was being sent in repr() format which trips up the IOS-XR
CLI causing it to hang at the prompt waiting for the banner termination
character. Instead of trying to wrap the banner in ', put it on the
user to specify their own delimiter character.
SUMMARY
This is believed to fix issue #77
ISSUE TYPE
COMPONENT NAME
iosxr_banner