Added no_log=False for type/update password (#54)

* Added no_log=False for type/update password * Fixed integration tests
ansible-collections · Mar 13, 2024 · f90377d · f90377d
1 parent 2de9836
commit f90377d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/plugins/modules/clickhouse_user.py b/plugins/modules/clickhouse_user.py
@@ -224,9 +224,12 @@ def main():
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         name=dict(type='str', required=True),
         password=dict(type='str', default=None, no_log=True),
-        type_password=dict(type='str', default='sha256_password', no_log=True),
+        type_password=dict(type='str', default='sha256_password', no_log=False),
         cluster=dict(type='str', default=None),
-        update_password=dict(type='str', choices=['always', 'on_create'], default='on_create'),
+        update_password=dict(
+            type='str', choices=['always', 'on_create'],
+            default='on_create', no_log=False
+        ),
     )
 
     # Instantiate an object of module class

diff --git a/tests/integration/targets/clickhouse_user/tasks/initial.yml b/tests/integration/targets/clickhouse_user/tasks/initial.yml
@@ -16,7 +16,7 @@
   ansible.builtin.assert:
     that:
     - result is changed
-    - result.executed_statements == ["CREATE USER test_user IDENTIFIED WITH ******** BY '********'"]
+    - result.executed_statements == ["CREATE USER test_user IDENTIFIED WITH sha256_password BY '********'"]
 
 - name: Test 1 - Check the actual state
   register: result
@@ -118,7 +118,7 @@
   ansible.builtin.assert:
     that:
     - result is changed
-    - result.executed_statements == ["ALTER USER test_user IDENTIFIED WITH ******** BY '********'"]
+    - result.executed_statements == ["ALTER USER test_user IDENTIFIED WITH sha256_password BY '********'"]
 
 - name: Drop test_user
   community.clickhouse.clickhouse_user: