Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse_user: refactor the code #71

Closed
Andersson007 opened this issue Jul 19, 2024 · 1 comment
Closed

clickhouse_user: refactor the code #71

Andersson007 opened this issue Jul 19, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Andersson007
Copy link
Contributor

Andersson007 commented Jul 19, 2024 •
edited
Loading

SUMMARY

Do this after merging #70

It's not good that we pass some args to the class methods explicitly but take some from module.params: this should be fixed in a separate PR. I'm not sure what approach to choose: let's discuss here:)
@Andersson007 Andersson007 added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 19, 2024
@Andersson007 Andersson007 mentioned this issue Jul 19, 2024
Merged
@Andersson007
Copy link
Contributor Author

Closed as complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andersson007