clickhouse_user: set default role

[Andersson007]

SUMMARY

See the changes

[Andersson007]

cc @aleksvagachev

[Andersson007]

wait a minute, got some errors locally, fixing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (8435902) to head (5887e2f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   85.42%   88.04%   +2.61%     
==========================================
  Files           6        8       +2     
  Lines         597      711     +114     
  Branches      109      138      +29     
==========================================
+ Hits          510      626     +116     
+ Misses         45       43       -2     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Andersson007]

I'll finish it after PTO

[Andersson007]

cc @aleksvagachev it's ready for review

[Andersson007]

i'm now thinking that maybe that append_role thing that used say in ansible.builtin.user module can be made more flexible? how about something like:

role_mode: append | remove | listed_only (default)
default_role_mode:  append | remove | listed_only (default)

On one hand that append_role it's how some of long-existing modules handle it - not saying it's good per se and probably it's not the best design but people are used to it. On the other hand, something like this feels more flexible.
What do you think @aleksvagachev ? Maybe you have a third option on your mind?

[aleksvagachev]

@Andersson007 I think it's interesting to add this. There is functionality for adding specific roles, but there is no functionality for removing specific roles)
It is probably necessary to form the idea that the module can perform only basic actions. And for more specific settings, it is better to use the clickhouse_client module. Otherwise, sooner or later it will become difficult to maintain the code, and users will get confused.

[Andersson007]

And for more specific settings, it is better to use the clickhouse_client module. Otherwise, sooner or later it will become difficult to maintain the code, and users will get confused.

I think the latest suggested implementation is OK in this particular case that it'll basically add only remove, so will not complicate the code much. Let me try

[Andersson007]

@aleksvagachev changed, the tests were green, please take another look

[aleksvagachev]

@Andersson007 Cool feature! Thanks for the contribution.

[Andersson007]

@aleksvagachev the community is always welcome:) thanks for reviewing and merging!