Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a parameter to set query execution settings #67

Merged

Conversation

aleksvagachev
Copy link
Collaborator

SUMMARY

In continuation #63 implemented the installation of any number of parameters

ISSUE TYPE
  • Feature Pull Request

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (543a995) to head (13539a6).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #67       +/-   ##
===========================================
+ Coverage   53.00%   86.29%   +33.29%     
===========================================
  Files           4        6        +2     
  Lines         200      591      +391     
  Branches       27      108       +81     
===========================================
+ Hits          106      510      +404     
+ Misses         87       44       -43     
- Partials        7       37       +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugins/modules/clickhouse_client.py Outdated Show resolved Hide resolved
plugins/modules/clickhouse_client.py Outdated Show resolved Hide resolved
@aleksvagachev
Copy link
Collaborator Author

@Andersson007 I corrected it for the dictionary

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksvagachev the implementation looks very good now, thanks for the contribution!

@Andersson007 Andersson007 merged commit 19bb2d3 into ansible-collections:main Jul 10, 2024
21 checks passed
@aleksvagachev aleksvagachev deleted the patch_set_settings branch September 8, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants