Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickhouse user refactor #74

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Clickhouse user refactor #74

merged 2 commits into from
Aug 26, 2024

Conversation

Andersson007
Copy link
Contributor

SUMMARY
  • Split long functions into several smaller
  • Less magic by passing arguments
  • Magic is preserved on class level only for very general frequently used things like self.changed, module.check_mode, self.client, name, etc.

@Andersson007
Copy link
Contributor Author

ready for review

@aleksvagachev aleksvagachev merged commit d1b3d41 into ansible-collections:main Aug 26, 2024
21 checks passed
@Andersson007
Copy link
Contributor Author

@aleksvagachev thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksvagachev aleksvagachev aleksvagachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andersson007 @aleksvagachev