-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added ip2location.io for IP geolocation lookup. #11170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
felixfontein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please note that you need to use the code formatter, and that you need to add tests. Please see CONTRIBUTING.md.
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@ip2location this PR contains the following merge commits: Please rebase your branch to remove these commits. |
|
Please don't forget to add tests (and check out CONTRIBUTING.md). Thanks. |
This comment was marked as outdated.
This comment was marked as outdated.
russoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the version typo, LGTM
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
plugins/modules/ip2location_info.py
Outdated
| response, info = fetch_url( | ||
| self.module, | ||
| url, | ||
| force=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted this in the test case below. Why did you have to use force=True? I don't recall the semantics for that.
SUMMARY
Added new IP geolocation lookup using the free IP2Location.io API service.
ISSUE TYPE
COMPONENT NAME
ip2locationio