added a vault_kv2_delete with destroy option

[Kloppi313]

SUMMARY

The vault_kv2_delete module can only delete data. There is little code change to also destroy. It seems more reasonable to add the option instead of creating a new module

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vault_kv2_delete

ADDITIONAL INFORMATION

Idea came up here #446.

Help needed:
How do I break the run, when destroy is true but versions is not set?

[briantist]

note: there are collection-wide CI failures at the moment that I need to deal with that aren't related to your PR:

• https://github.com/ansible-collections/community.hashi_vault/actions/runs/10421215850

---

While I will consider this change rather than a dedicated destroy module, I do think some of the reasons for having a separate module still stand: namely around testing and option combinations (like versions being required now but only in certain circumstances). Maybe they aren't as severe as I thought either though.

I'll point out that coverage for the existing module is 100%:

• https://app.codecov.io/gh/ansible-collections/community.hashi_vault/blob/main/plugins%2Fmodules%2Fvault_kv2_delete.py

I will not want that bring that lower, and this PR will need both integration and unit test additions. The process of adding those should begin highlight how much complexity (or not) this change ends up adding, vs. having a dedicated module, so let's see how adding the tests play out.

(and of course: coverage number is not the end-all-be-all: 100% coverage doesn't mean we're testing all the right things, but <100% does mean we are missing some code paths; I will try to point out any test cases I think are important when I have proper time to review again)

[Kloppi313]

Just my 2cents why I did it within this module:

• I am no programmer, I am sysadmin, so the copycat approach is easier for me
• no code duplication with a new module
• I think I would be maintainer of this new module, because I am no programmer, that might be ne good choice
• a new module would also need tests(?)

Please be advised: the case destroy == true && versions not defined is not covered within the if/else branch, as I do not know how to exit correctly for ansible. This should be a finding of tests