Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self hosted #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

self hosted #32

wants to merge 5 commits into from

Conversation

cinco
Copy link

@cinco cinco commented May 23, 2023

  • Enable self-hosted healthchecks.io instances
  • Fix uuid retrieval on self-hosted instances
  • 📝 docs: add documentation for using a private instance of Healthchecks.io in README.md and CHANGELOG.rst

dsander and others added 3 commits September 13, 2022 00:53
@dsander
Enable self-hosted healthchecks.io instances
55310bd 
By specifying `api_base_url` users can connect to their own self-hosted
instances.
@dsander
Fix uuid retrieval on self-hosted instances
69f9443 
The UUID is always the last component of the URL. For self-hosted
instances the ping url is `<scheme>://<domain>/ping/<uuid>` on
healthchecks.io it is `https://hc-ping.com/<uuid>`.
@cinco
📝 docs: add documentation for using a private instance of Healthcheck…
47495d1 
…s.io in README.md and CHANGELOG.rst
@cinco cinco temporarily deployed to integration May 23, 2023 04:25 — with GitHub Actions Inactive
@cinco cinco mentioned this pull request May 23, 2023
Open
@mamercad
Copy link
Collaborator

Thanks for working on this, instead of updating CHANGELOG.rst manually (there's a tool to create it for new releases), please reverse the change and create a changelog fragment instead.

@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.11%. Comparing base (eb4726c) to head (57bdad0).
Report is 6 commits behind head on main.

Files Patch % Lines
plugins/module_utils/healthchecksio.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   76.50%   74.11%   -2.39%     
==========================================
  Files           9        8       -1     
  Lines         366      367       +1     
  Branches       63       54       -9     
==========================================
- Hits          280      272       -8     
- Misses         53       54       +1     
- Partials       33       41       +8
Flag Coverage Δ
integration 74.11% <71.42%> (-0.20%) ⬇️
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mamercad
mamercad reviewed May 26, 2023
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@cinco cinco temporarily deployed to integration May 27, 2023 03:02 — with GitHub Actions Inactive
mamercad
mamercad reviewed May 27, 2023
View reviewed changes
changelogs/fragments/32-selfhosted.yaml
@@ -0,0 +1,2 @@
minor_changes:
- base_url - Support for using a private instance of Healthchecks.io (https://github.com/ansible-collections/community.healthchecksio/pull/32).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first word of a changelog fragment is supposed to be lower case, i.e., "support". Also, the scope of this change is pretty much collection-wide, so, perhaps drop it altogether.

minor_changes:
- Add support for using a private instance of Healthchecks.io (https://github.com/ansible-collections/community.healthchecksio/pull/32).

mamercad
mamercad reviewed May 27, 2023
View reviewed changes
plugins/module_utils/healthchecksio.py
@@ -117,6 +123,19 @@ def healthchecksio_argument_spec():
required=True,
no_log=True,
),
api_base_url=dict(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to run black on this file to get the test to pass.

mamercad
mamercad requested changes May 27, 2023
View reviewed changes
Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes to the changelog fragment and running black please.

@Penagwin Penagwin mentioned this pull request Sep 7, 2023
Open
@bgachenot bgachenot mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamercad mamercad mamercad requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cinco @mamercad @dsander