Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow connections without certificates #609

Merged

Conversation

LeoSpyke
Copy link
Contributor

SUMMARY

Gives the ability to specify whether to bypass client certificate validation for clients that do not present a certificate.
Documentation reference here.

There are also some README(s) typos fixes and formatting.

ISSUE TYPE
  • Feature Pull Request
  • Docs Pull Request
COMPONENT NAME

roles involved: mongod, mongos, config

ADDITIONAL INFORMATION

A new mongodb_allow_connections_without_certificates configuration variable is introduced.
As per documentation: "In most cases, it is important to ensure that clients present valid certificates. However, if you have clients that cannot present a client certificate or are transitioning to using a certificate, you may only want to validate certificates from clients that present a certificate".
This fix would enable the above mentioned scenarios where the clients involved have different requirements or capabilities.

- ansible.builtin.include_role:
    name: community.mongodb.mongodb_mongod
  vars:
    mongodb_allow_connections_without_certificates: true

It defaults to false, so it is completely opt-in.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70e8344) 73.08% compared to head (cde4953) 73.08%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files           6        6           
  Lines         929      929           
  Branches      143      143           
=======================================
  Hits          679      679           
  Misses        213      213           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhysmeister rhysmeister merged commit cc22eef into ansible-collections:master Oct 26, 2023
209 checks passed
@LeoSpyke LeoSpyke deleted the feat-conns-without-certs branch October 27, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants