Fix integration tests

ansible-collections · Dec 4, 2023 · 44ce470 · 44ce470
1 parent 29513ab
commit 44ce470
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/tests/integration/targets/vmware_about_info/tasks/main.yml b/tests/integration/targets/vmware_about_info/tasks/main.yml
@@ -15,7 +15,7 @@
 
 - assert:
     that:
-      - about.about_info["{{ item }}"] is defined
+      - about.about_info[item] is defined
   with_items:
     - api_type
     - api_version
@@ -40,7 +40,7 @@
 
 - assert:
     that:
-      - about.about_info["{{ item }}"] is defined
+      - about.about_info[item] is defined
   with_items:
     - api_type
     - api_version

diff --git a/tests/integration/targets/vmware_category/tasks/associable_obj_test.yml b/tests/integration/targets/vmware_category/tasks/associable_obj_test.yml
@@ -35,4 +35,4 @@
 - name: Check if we get correct associable datatype for {{ category_name }}
   assert:
     that:
-      - "'{{ expected_result }}' in {{ category_datatype }}"
+      - "expected_result in category_datatype"
diff --git a/tests/integration/targets/vmware_dvs_portgroup/tasks/main.yml b/tests/integration/targets/vmware_dvs_portgroup/tasks/main.yml
@@ -407,7 +407,7 @@
   assert:
     that:
         - not dvs_pg_result_0013.changed
-        - "'vlan_id range 1-4096 specified is incorrect. The valid vlan_id range is from 0 to 4094.' == '{{ dvs_pg_result_0013.msg }}'"
+        - "'vlan_id range 1-4096 specified is incorrect. The valid vlan_id range is from 0 to 4094.' == dvs_pg_result_0013.msg"
 
 - name: Change VLAN on basic VLAN portgroup
   community.vmware.vmware_dvs_portgroup:
@@ -508,7 +508,7 @@
   assert:
     that:
         - not dvs_pg_result_0018.changed
-        - "'No private vlan with id 10 in distributed vSwitch {{ dvswitch1 }}' == '{{ dvs_pg_result_0018.msg }}'"
+        - "'No private vlan with id 10 in distributed vSwitch {{ dvswitch1 }}' == dvs_pg_result_0018.msg"
 
 - name: Run tests and clean up
   block:

diff --git a/tests/integration/targets/vmware_folder_info/tasks/main.yml b/tests/integration/targets/vmware_folder_info/tasks/main.yml
@@ -31,7 +31,7 @@
 
 - assert:
     that:
-      - "{{ item }} is defined"
+      - "item is defined"
   with_items:
   - folder_info_0001['folder_info']
   - folder_info_0001['flat_folder_info']

diff --git a/tests/integration/targets/vmware_guest_controller/tasks/main.yml b/tests/integration/targets/vmware_guest_controller/tasks/main.yml
@@ -50,8 +50,8 @@
   assert:
     that:
       - "add_disk_controller.changed == true"
-      - "{{ add_disk_controller.disk_controller_data.scsi | length | int }} == {{ scsi_num | int + 1 }}"
-      - "{{ add_disk_controller.disk_controller_data.sata | length | int }} == {{ sata_num | int + 1 }}"
+      - "add_disk_controller.disk_controller_data.scsi | length | int == scsi_num | int + 1"
+      - "add_disk_controller.disk_controller_data.sata | length | int == sata_num | int + 1"
 
 - name: delete specified disk controllers
   vmware_guest_controller:
@@ -76,5 +76,5 @@
   assert:
     that:
       - "del_disk_controller.changed == true"
-      - "{{ del_disk_controller.disk_controller_data.sata | length | int }} == {{ sata_num | int }}"
-      - "{{ del_disk_controller.disk_controller_data.scsi | length | int }} == {{ scsi_num | int }}"
+      - "del_disk_controller.disk_controller_data.sata | length | int == sata_num | int"
+      - "del_disk_controller.disk_controller_data.scsi | length | int == scsi_num | int"