fix(vmware_vsan_health_info): Return dict instead of JSON string (#1706)

fix(vmware_vsan_health_info): Return dict instead of JSON string SUMMARY Fixes #1648 While the module description says that the return type should be a dict, it actually returns a JSON string ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_vsan_health_info ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <m@riolenz.de>
ansible-collections · Apr 29, 2023 · ccd8405 · ccd8405
1 parent ab1d7db
commit ccd8405
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/fragments/1706-vmware_vsan_health_info.yml b/changelogs/fragments/1706-vmware_vsan_health_info.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  -  vmware_vsan_health_info - Fix return value (https://github.com/ansible-collections/community.vmware/pull/1706).
diff --git a/plugins/modules/vmware_vsan_health_info.py b/plugins/modules/vmware_vsan_health_info.py
@@ -167,7 +167,7 @@ def gather_info(self):
 
         health = json.dumps(cluster_health, cls=VmomiSupport.VmomiJSONEncoder, sort_keys=True, strip_dynamic=True)
 
-        self.module.exit_json(changed=False, vsan_health_info=health)
+        self.module.exit_json(changed=False, vsan_health_info=json.loads(health))
 
 
 def main():
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- vmware_vsan_health_info - Fix return value (https://github.com/ansible-collections/community.vmware/pull/1706).