Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_datastore_cluster: Add automation levels, vm overrides, Space and IO Load Balance Config #1734

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

vmware_datastore_cluster: Add automation levels, vm overrides, Space and IO Load Balance Config #1734

wants to merge 17 commits into from

Conversation

Nina2244
Copy link
Contributor

SUMMARY

Add the automation levels:

  • Space balance
  • I/O balance
  • Rule enforcement
  • Vm evacuation

and add Space Load Balance Config

and the possibility to override the datastore cluster settings (keep vmdks together and automation level) for Virtual Machines.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_datastore_cluster

ADDITIONAL INFORMATION

New Pull Request after Rebase #1278

@Nina2244 Nina2244 mentioned this pull request May 12, 2023
Closed
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b7bad18f8c3f40bb860fece84eef05df

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 9m 03s
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 9m 10s (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 9m 29s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 51s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 52s

@mariolenz
Copy link
Collaborator

The CI fails with:

ERROR: Found 4 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/vmware_datastore_cluster.py:368:161: E501: line too long (200 > 160 characters)
ERROR: plugins/modules/vmware_datastore_cluster.py:374:161: E501: line too long (201 > 160 characters)
ERROR: plugins/modules/vmware_datastore_cluster.py:380:161: E501: line too long (207 > 160 characters)
ERROR: plugins/modules/vmware_datastore_cluster.py:386:161: E501: line too long (192 > 160 characters)

Could you shorten those lines, or refactor them into several lines with <= 160 characters each?

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/151689c07a994f268d03d99179a1c8ff

✔️ ansible-tox-linters SUCCESS in 8m 47s
✔️ build-ansible-collection SUCCESS in 9m 24s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 40s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 21s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 56s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 33s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 13m 07s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 46s

@Nina2244
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/03475d4511644c60b523689fec6f49a3

✔️ ansible-tox-linters SUCCESS in 9m 27s
✔️ build-ansible-collection SUCCESS in 10m 08s
❌ ansible-test-sanity-docker-devel FAILURE in 17m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 03s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 14s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 59s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 27s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 17m 28s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 FAILURE in 18m 30s
✔️ ansible-galaxy-importer SUCCESS in 4m 14s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3a75d509907941999b11d67cc2e53745

✔️ ansible-tox-linters SUCCESS in 8m 36s
✔️ build-ansible-collection SUCCESS in 10m 43s
❌ ansible-test-sanity-docker-devel FAILURE in 12m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 18s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 20s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 45s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 04s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 FAILURE in 16m 00s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 6m 02s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5219846a8d1a4ed69ea21ad174e1376a

✔️ ansible-tox-linters SUCCESS in 8m 29s
✔️ build-ansible-collection SUCCESS in 9m 25s
❌ ansible-test-sanity-docker-devel FAILURE in 10m 18s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 30s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 01s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 56s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 06s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 15m 45s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 42s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ec4ebd28fc3341ba86a73f754582b5d9

✔️ ansible-tox-linters SUCCESS in 8m 35s
✔️ build-ansible-collection SUCCESS in 9m 11s
❌ ansible-test-sanity-docker-devel FAILURE in 10m 15s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 40s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 09s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 40s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 50s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 15m 11s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 17m 32s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@mariolenz
Copy link
Collaborator

@Nina2244 I'm beginning to think that we should not introduce new parameters with defaults (or new defaults for existing parameters) in a minor version. You see, this might break things for the users.

For example, if people have configured the space balance automation level to manual and run the current version of the module, there won't be any change. But merging this PR means there will be a change to automated. So please remove the defaults and just ignore those parameters if they're not defined.

If you think those defaults a good idea, we could open an issue to implement them in the next major release. There's a milestone where we could add this so we don't forget.

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/78f90a65b4fa488c9df9812a3d8ac1fe

❌ ansible-tox-linters FAILURE in 8m 35s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b7e2fcf1a6b74944a3617b708fede387

❌ ansible-tox-linters FAILURE in 8m 32s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3f56601e0f1d4199bcedd9241ac8774a

✔️ ansible-tox-linters SUCCESS in 8m 41s
✔️ build-ansible-collection SUCCESS in 9m 22s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 15m 03s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 46s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/58fefc9f069b427392f6946ba1bb7022

❌ ansible-tox-linters POST_FAILURE in 9m 04s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@Nina2244
Copy link
Contributor Author

Nina2244 commented Jun 7, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/73f1b68bfcaa442c97119f3837ebe1ad

❌ ansible-tox-linters FAILURE in 8m 42s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@Nina2244
Copy link
Contributor Author

Nina2244 commented Jun 7, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7f905fdf37c3446d874eac67e0c36653

✔️ ansible-tox-linters SUCCESS in 9m 17s
✔️ build-ansible-collection SUCCESS in 9m 42s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 21m 50s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 46s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 1h 06m 20s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 56m 20s
✔️ ansible-galaxy-importer SUCCESS in 4m 48s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/01576d99235d4dfeb3fe2d34295a3469

✔️ ansible-tox-linters SUCCESS in 9m 37s
✔️ build-ansible-collection SUCCESS in 10m 17s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 16m 08s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 25s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ccba6c651e0c4885b6e0cec1cb4cb299

✔️ ansible-tox-linters SUCCESS in 9m 21s
✔️ build-ansible-collection SUCCESS in 10m 15s
❌ ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006211403 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006211404 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006211405 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006211406 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 51s

@mariolenz
Copy link
Collaborator

@Nina2244 FYI: I think the sanity tests should work now, this seems to fix the GH action.

However, it looks like we still have some problems with the integration tests 😢

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e1fa53f5d7744353910fdda4a48e2eda

✔️ ansible-tox-linters SUCCESS in 10m 36s
✔️ build-ansible-collection SUCCESS in 11m 06s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable216 FAILURE in 19m 58s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1a06a452169d4ca2b02e8f3a13ea9348

✔️ ansible-tox-linters SUCCESS in 11m 29s
✔️ build-ansible-collection SUCCESS in 12m 03s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 FAILURE in 14m 16s
✔️ ansible-galaxy-importer SUCCESS in 3m 55s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/24a71f61d7df4d2489af0c2f9a7377d9

❌ ansible-tox-linters FAILURE in 9m 42s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/cf70ab4f0026477ca7fe71f23d39adbd

✔️ ansible-tox-linters SUCCESS in 9m 45s
✔️ build-ansible-collection SUCCESS in 10m 17s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 16m 23s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 02s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nina2244 @mariolenz