Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 5.0.0 dependencies #2163

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Sep 9, 2024

Fixes #2123

SUMMARY

Require pyVmomi >= 8.0.3.0.1 in order to be able to drop the requirement on the vSAN Management SDK for Python, which has been a pain to install.

Also, substitute the requirement for / dependency on https://github.com/vmware/vsphere-automation-sdk-python.git with the PyPI packages vmware-vcenter and vmware-vapi-common-client.

Additionally, at least one of those pulls in requirements so we can remove it, too.

Also document the dependency on ansible-core 2.17.0.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

requirements.txt
README.md

ADDITIONAL INFORMATION

vSAN Management SDK for Python
vsphere-automation-sdk-python PyPI package
#2153

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz mariolenz changed the title [WIP] Update 5.0.0 dependencies Update 5.0.0 dependencies Sep 10, 2024
@mariolenz
Copy link
Collaborator Author

mariolenz commented Sep 10, 2024

It looks like we can get rid of some dependencies that were not available on PyPI until recently.

@ihumster What do you think? The CI seems to be happy. BTW if you want to implement any other breaking changes, please let me know. I'm working on the next major release ATM.

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/25164fa5ebee4449a56d23fee92a5aae

✔️ ansible-tox-linters SUCCESS in 7m 44s
✔️ build-ansible-collection SUCCESS in 6m 23s
✔️ ansible-galaxy-importer SUCCESS in 5m 09s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ac0dd76 into ansible-collections:main Sep 17, 2024
11 checks passed
@mariolenz mariolenz deleted the 5.0.0-dependencies branch September 17, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Support for pyVmomi < 8.0.3 and vSAN Management SDK
1 participant