Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Complexity #426

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

arulkumar9690
Copy link
Contributor

@arulkumar9690 arulkumar9690 commented Aug 8, 2024

SUMMARY
Password Complexity - Module implementation

GitHub Issues
N/A.

ISSUE TYPE
Feature Pull Request

COMPONENT NAME
sonic_password_complexity

ADDITIONAL INFORMATION

OUTPUT

Regression test HTML report:
Password_Complexity.pdf

Checklist:
[yes ] I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
[ yes] I have verified that new and existing unit tests pass locally with my changes
[ yes] I have not allowed coverage numbers to degenerate
[ yes] I have maintained at least 90% code coverage
[ yes] I have commented my code, particularly in hard-to-understand areas
[ yes] I have made corresponding changes to the documentation
[ yes] I have added tests that prove my fix is effective or that my feature works
[ yes] I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
[ yes] I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

How Has This Been Tested?
Ran lots of unit testing and regression testing on some SONIC target systems.

@arulkumar9690 arulkumar9690 changed the title Ansible Collections - Password Complexity Changes Password Complexity Aug 8, 2024
@kerry-meyer kerry-meyer added the new_resource_module This pull request adds a new resource module label Aug 19, 2024
@mingjunzhang2019 mingjunzhang2019 mentioned this pull request Sep 3, 2024
9 tasks
@kerry-meyer kerry-meyer mentioned this pull request Sep 5, 2024
@kerry-meyer
Copy link
Collaborator

It would be better to add the relevant code sections from the following PRs to the already existing "sonic_system" resource module. The recent PRs for "auditd" (#405) and "Ansible support for versatile hash feature" (#401) can be used as examples for doing this. Adding the entire set of supporting base files and the required accompanying minimum code for each of these small sets of additional options creates a significant amount of additional lines of code and files to the repo and would require an undesirable added amount of maintenance overhead time and resources.

Each of the new options can be added to the "sonic_system" module/argspec as a new dict named based on the supported feature (e.g. pw_options and banner), or just a single new option (exec_timeout):

#427
#426
#425

Please refactor these PRs as described above into one new PR unless there is some reason that these should all be separate resource modules. (If you feel that they should be separate modules, please explain the reasoning for this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants