Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible support for REST server cipher suite configuration #464

Merged

Conversation

balasubramaniam-k
Copy link
Contributor

@balasubramaniam-k balasubramaniam-k commented Oct 8, 2024

SUMMARY
Resource module changes for REST server cipher suite.

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME
sonic_mgmt_servers

RELATED PR
ansible-network/resource_module_models#276

OUTPUT
regression-2024-10-08-13-37-18.html.pdf
mgmt_servers_config_UT_check_mode.log
Scaled version of regression-2024-10-08-13-37-18.html.pdf

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 added the enhancement New feature or request label Oct 21, 2024
Copy link
Collaborator

@stalabi1 stalabi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code changes look good, just one minor change suggestion. Also, could you please repost the regression report pdf? Some columns got cut off. Perhaps you may need to print to pdf in landscape or you could try scaling it.

@stalabi1 stalabi1 added this to the v3.1.0 milestone Oct 21, 2024
Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@balasubramaniam-k
Copy link
Contributor Author

Your code changes look good, just one minor change suggestion. Also, could you please repost the regression report pdf? Some columns got cut off. Perhaps you may need to print to pdf in landscape or you could try scaling it.

@stalabi1 Have attached the scaled version of regression report output in the description

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currently proposed change set, additional tests cases, and corresponding test results look good.

Thank you for implementing this new option for the sonic_mgmt_servers resource module.

Approved.

@kerry-meyer kerry-meyer merged commit 8bed1c4 into ansible-collections:main Nov 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants