-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible support for REST server cipher suite configuration #464
Ansible support for REST server cipher suite configuration #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code changes look good, just one minor change suggestion. Also, could you please repost the regression report pdf? Some columns got cut off. Perhaps you may need to print to pdf in landscape or you could try scaling it.
Co-authored-by: stalabi1 <54641848+stalabi1@users.noreply.github.com>
@stalabi1 Have attached the scaled version of regression report output in the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The currently proposed change set, additional tests cases, and corresponding test results look good.
Thank you for implementing this new option for the sonic_mgmt_servers resource module.
Approved.
SUMMARY
Resource module changes for REST server cipher suite.
ISSUE TYPE
COMPONENT NAME
sonic_mgmt_servers
RELATED PR
ansible-network/resource_module_models#276
OUTPUT
regression-2024-10-08-13-37-18.html.pdf
mgmt_servers_config_UT_check_mode.log
Scaled version of regression-2024-10-08-13-37-18.html.pdf
Checklist: