Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing regression tests for vxlan #471

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

aida-shumburo
Copy link
Collaborator

@aida-shumburo aida-shumburo commented Oct 18, 2024

SUMMARY

Fix the failing vxlan regression tests

GitHub Issues

N/A

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_vxlan

OUTPUT
Ansible Report:

suppress_vlan_neigh.html.pdf

Raw Regression Test Output:

suppress_vlan_neigh.txt

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran the regression test to ensure that all tests pass

@aida-shumburo aida-shumburo marked this pull request as ready for review October 18, 2024 22:09
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The posted proposed changes and corresponding test results look good, but please also add invocation of the cleanup task from the main task after completion of the main test loop.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically, this is all fine now.

I am posting one very simple request for parameterizing the VRF names in the cleanup task.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these follow-up changes and, especially, for providing the fix for this problem.

All posted code changes and corresponding test results look good now.

Approved.

@kerry-meyer kerry-meyer merged commit 06e9d99 into ansible-collections:main Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants