-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing regression tests for vxlan #471
Fix failing regression tests for vxlan #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The posted proposed changes and corresponding test results look good, but please also add invocation of the cleanup task from the main task after completion of the main test loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logically, this is all fine now.
I am posting one very simple request for parameterizing the VRF names in the cleanup task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making these follow-up changes and, especially, for providing the fix for this problem.
All posted code changes and corresponding test results look good now.
Approved.
SUMMARY
Fix the failing vxlan regression tests
GitHub Issues
N/A
ISSUE TYPE
COMPONENT NAME
sonic_vxlan
OUTPUT
Ansible Report:
suppress_vlan_neigh.html.pdf
Raw Regression Test Output:
suppress_vlan_neigh.txt
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration