Skip to content

Commit

Permalink
changes based on review feedback
Browse files Browse the repository at this point in the history
this change reverts CONTRIBUTING.md to original state
  • Loading branch information
yurnov committed May 6, 2024
1 parent bb476e6 commit 7822184
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ You can install ``collection_prep`` using

After installation, you can update documentation

# collection_prep_add_docs -p /<PATH_OF_COLLECTION>/kubernetes.core
# collection_prep_add_docs -p /<PATH_OF_COLLECTION>/kubernetes/core

Review the changes and create a pull request using updated files.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
minor_changes:
- kubectl - added support of local enviroment variable that will be used for kubectl and may be requried for establishing connections ifself (https://github.com/ansible-collections/kubernetes.core/pull/702)
- kubectl - added support of local enviroment variable that will be used for kubectl and may be requried for establishing connections ifself (https://github.com/ansible-collections/kubernetes.core/pull/702)
5 changes: 2 additions & 3 deletions plugins/connection/kubectl.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,11 +318,10 @@ def _local_env(self):
if local_env_vars:
if isinstance(local_env_vars, dict):
local_env_vars = json.dumps(local_env_vars)
local_env = dict(os.environ)
local_env = os.environ.copy()
local_env.update(json.loads(local_env_vars))
return local_env
else:
return None
return None

def _connect(self, port=None):
"""Connect to the container. Nothing to do"""
Expand Down

0 comments on commit 7822184

Please sign in to comment.