Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kustomize.py add --enable-helm support #592

Merged
merged 6 commits into from
May 13, 2024
Merged

Update kustomize.py add --enable-helm support #592

merged 6 commits into from
May 13, 2024

Conversation

gotsysdba
Copy link
Contributor

Add --enable-helm support

SUMMARY

Fixes #568

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Lookup plugin: kubernetes.core.kustomize

ADDITIONAL INFORMATION

Current and maintained arg:

lookup('kubernetes.core.kustomize', dir=item)

Additional feature args:

lookup('kubernetes.core.kustomize', dir=item, enable_helm=false)
lookup('kubernetes.core.kustomize', dir=item, enable_helm=true)

@gotsysdba
Update kustomize.py
afded64 
Add `--enable-helm` support
@gotsysdba gotsysdba changed the title Update kustomize.py Update kustomize.py add --enable-heml support Feb 28, 2023
@gotsysdba gotsysdba changed the title Update kustomize.py add --enable-heml support Update kustomize.py add --enable-helm support Feb 28, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ca1be0da602b44babaf214d51fa21315

✔️ build-ansible-collection SUCCESS in 6m 48s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 08s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 30s (non-voting)
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 10m 45s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 19s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 7m 34s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 27s
✔️ ansible-test-splitter SUCCESS in 4m 38s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 15m 07s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 6m 49s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 7m 06s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 6m 42s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 6m 47s
❌ ansible-tox-linters FAILURE in 10m 19s
❌ ansible-test-changelog FAILURE in 4m 24s
✔️ ansible-galaxy-importer SUCCESS in 3m 22s
Skipped 10 jobs

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3ba998c8f074414b85a63045b44a985d

✔️ build-ansible-collection SUCCESS in 6m 47s
❌ ansible-test-sanity-docker-devel FAILURE in 7m 43s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 37s (non-voting)
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 9m 46s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 9m 40s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 7m 41s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 5m 43s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 6m 48s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 7m 17s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 8m 17s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 12m 09s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 6m 40s
❌ ansible-tox-linters FAILURE in 10m 19s
❌ ansible-test-changelog FAILURE in 4m 26s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s
Skipped 10 jobs

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/121675d4666646b59b9e53141f694f0a

✔️ build-ansible-collection SUCCESS in 6m 56s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 28s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 10m 50s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 19s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 59s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 09s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 18s
✔️ ansible-test-splitter SUCCESS in 4m 42s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 10m 18s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 9m 59s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 10m 10s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 14m 10s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 9m 57s
✔️ ansible-tox-linters SUCCESS in 10m 39s
❌ ansible-test-changelog FAILURE in 4m 17s
✔️ ansible-galaxy-importer SUCCESS in 4m 06s
Skipped 10 jobs

@apinter
Copy link

apinter commented Nov 30, 2023

Bump +1
Just used this code, works fine. Could this get into the upstream version?

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e84ac005e9624021b1aabebad7a8e5cc

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 7m 59s

@apinter apinter mentioned this pull request Dec 4, 2023
Closed
@bdsoha
Copy link

bdsoha commented May 13, 2024

@gotsysdba Any updates on this?

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/aace28cd2be1401ba2e4732ff90292a9

✔️ ansible-galaxy-importer SUCCESS in 5m 00s
✔️ build-ansible-collection SUCCESS in 8m 23s

@gotsysdba
Copy link
Contributor Author

@gravesm (apologies for pinging directly, seen you as an active maintainer). Have I missed something to get approval for this? been stuck here for a while.

gravesm
gravesm reviewed May 13, 2024
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gotsysdba Thanks for the ping. Sorry, this got lost. This will need a changelog fragment, but otherwise looks good.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e48247402d58462ead784a732b128da1

✔️ ansible-galaxy-importer SUCCESS in 5m 44s
✔️ build-ansible-collection SUCCESS in 11m 58s

@gotsysdba gotsysdba requested a review from gravesm May 13, 2024 16:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/14f9bbeab7ca4a4291f423522a70fdda

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 8m 34s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0408aa9 into ansible-collections:main May 13, 2024
38 checks passed
@patchback Patchback
Copy link

patchback bot commented May 13, 2024 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/0408aa93285d82b3a01d9e427c90e4bfeb92f189/pr-592

Backported as #712

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 13, 2024
@gotsysdba @patchback
Update kustomize.py add --enable-helm support (#592)
ca99e3b 
Update kustomize.py add --enable-helm support

Add --enable-helm support
SUMMARY
Fixes #568
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Lookup plugin: kubernetes.core.kustomize
ADDITIONAL INFORMATION
Current and maintained arg:
lookup('kubernetes.core.kustomize', dir=item)

Additional feature args:
lookup('kubernetes.core.kustomize', dir=item, enable_helm=false)
lookup('kubernetes.core.kustomize', dir=item, enable_helm=true)

Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit 0408aa9)
@patchback patchback bot mentioned this pull request May 13, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 13, 2024
@patchback
Update kustomize.py add --enable-helm support (#592) (#712)
ddd7e79 
[PR #592/0408aa93 backport][stable-3] Update kustomize.py add --enable-helm support

This is a backport of PR #592 as merged into main (0408aa9).
Add --enable-helm support
SUMMARY
Fixes #568
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
Lookup plugin: kubernetes.core.kustomize
ADDITIONAL INFORMATION
Current and maintained arg:
lookup('kubernetes.core.kustomize', dir=item)

Additional feature args:
lookup('kubernetes.core.kustomize', dir=item, enable_helm=false)
lookup('kubernetes.core.kustomize', dir=item, enable_helm=true)

Reviewed-by: Mike Graves <mgraves@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
backport-3 mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to pass command line args to Kustomize to install helm charts
4 participants
@gotsysdba @apinter @bdsoha @gravesm