Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignore files and entries which are not useful anymore #667

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Remove ignore files and entries which are not useful anymore #667

merged 2 commits into from
Dec 12, 2023

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

Remove ignore files and entries which are not useful anymore

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis alinabuzachis mentioned this pull request Dec 11, 2023
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c005f03cdeb04211846214ec1be62a91

✔️ ansible-galaxy-importer SUCCESS in 3m 35s
✔️ build-ansible-collection SUCCESS in 7m 40s

gravesm
gravesm reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also remove tests/sanity/refresh_ignore_files and the corresponding line from the ignore files. This was really only used when things were more complicated with ansible < 2.12. I think we can probably just manage ignore files by hand now.

@alinabuzachis
Remove useless tests/sanity/ignore-2.*.txt files
c9eb920 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f630c7b9e43040bb837bab170ba300e9

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 7m 41s

@alinabuzachis
Add tests/sanity/ignore-2.17.txt
c0f83bc 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ee68b597ba1d4ede96278763eadabd65

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 7m 56s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/30526e5629284583984b6a217d1217e4

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 8m 17s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8d15489 into ansible-collections:main Dec 12, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

@hakbailey hakbailey hakbailey approved these changes

Assignees
No one assigned
Labels
backport-3 mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alinabuzachis @gravesm @hakbailey