-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecation version for merge_type=json #700
Update deprecation version for merge_type=json #700
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 16s |
9469892
to
1be85ac
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 32s |
1be85ac
to
cfa98db
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 12s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 57s |
a4c1bd8
into
ansible-collections:main
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #718 🤖 @patchback |
Update deprecation version for merge_type=json SUMMARY When looking at the parts of plugins/module_utils/common.py and plugins/module_utils/k8s/service.py during the post 3.0.0 release (see https://github.com/ansible-collections/kubernetes.core/pull/663/files#diff-9ee2d0860a5643da4e1f35136e9e7c3a41c5f2fd2952c197e7e32b941e5a301c) that affect merge_type when set to json, I don't believe merge_type=json was deprecated for (and removed from) the k8s module, and instead the deprecation version has moved to 4.0.0. Hence, the documentation update. ISSUE TYPE Docs Pull Request COMPONENT NAME k8s module Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit a4c1bd8)
[PR #700/a4c1bd85 backport][stable-3] Update deprecation version for merge_type=json This is a backport of PR #700 as merged into main (a4c1bd8). SUMMARY When looking at the parts of plugins/module_utils/common.py and plugins/module_utils/k8s/service.py during the post 3.0.0 release (see https://github.com/ansible-collections/kubernetes.core/pull/663/files#diff-9ee2d0860a5643da4e1f35136e9e7c3a41c5f2fd2952c197e7e32b941e5a301c) that affect merge_type when set to json, I don't believe merge_type=json was deprecated for (and removed from) the k8s module, and instead the deprecation version has moved to 4.0.0. Hence, the documentation update. ISSUE TYPE Docs Pull Request COMPONENT NAME k8s module Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY
When looking at the parts of
plugins/module_utils/common.py
andplugins/module_utils/k8s/service.py
during the post3.0.0
release (see https://github.com/ansible-collections/kubernetes.core/pull/663/files#diff-9ee2d0860a5643da4e1f35136e9e7c3a41c5f2fd2952c197e7e32b941e5a301c) that affectmerge_type
when set tojson
, I don't believemerge_type=json
was deprecated for (and removed from) thek8s
module, and instead the deprecation version has moved to4.0.0
. Hence, the documentation update.ISSUE TYPE
COMPONENT NAME
k8s
module